Issue 13051: Secure default for cajoled content

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13051: Secure default for cajoled content (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years ago by Jasvir

Modified:
16 years, 6 months ago

Reviewers:
louiscryan

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Submitted: http://svn.apache.org/viewvc?view=rev&revision=747682

Patch Set 2 : Corrected error in uri sanitizing regular expression #

Total comments: 1

Patch Set 3 : Added tests and enabled error reporting #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -27 lines)			Patch
M	features/caja/caja.js	View	1 2	2 chunks	+1 line, -13 lines	0 comments	Download
M	features/opensocial-reference/container.js	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java	View	1 2	5 chunks	+51 lines, -4 lines	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java	View		6 chunks	+24 lines, -1 line	0 comments	Download
A	java/server/src/test/resources/endtoend/failCajaTest.xml	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	javascript/samplecontainer/samplecontainer.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

louiscryan

Looks fine. Can you add unit test and Ill commit. http://codereview.appspot.com/13051/diff/10/11 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/13051/diff/10/11#newcode99 ...

16 years, 12 months ago (2009-02-24 02:10:31 UTC) #1

Updated.

Expand All Messages | Collapse All Messages