Issue 1303042: code review 1303042: gc: new typechecking rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1303042: code review 1303042: gc: new typechecking rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: new typechecking rules * Code for assignment, conversions now mirrors spec. * Changed some snprint -> smprint. * Renamed runtime functions to separate interface conversions from type assertions: convT2I, assertI2T, etc. * Correct checking of \U sequences. Fixes issue 840. Fixes issue 830. Fixes issue 778.

Patch Set 1 #

Patch Set 2 : code review 1303042: gc: implement and test stricter assignment rules #

Patch Set 3 : code review 1303042: gc: new typechecking rules #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1481 lines, -1342 lines)			Patch
M	src/cmd/6g/cgen.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/bits.c	View		1 chunk	+11 lines, -14 lines	0 comments	Download
M	src/cmd/gc/builtin.c.boot	View	1 2	1 chunk	+16 lines, -12 lines	0 comments	Download
M	src/cmd/gc/closure.c	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/cmd/gc/const.c	View	2	3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	2	6 chunks	+12 lines, -7 lines	0 comments	Download
M	src/cmd/gc/export.c	View	2	3 chunks	+25 lines, -4 lines	0 comments	Download
M	src/cmd/gc/go.h	View	2	8 chunks	+9 lines, -16 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	2	7 chunks	+22 lines, -4 lines	0 comments	Download
M	src/cmd/gc/print.c	View		5 chunks	+5 lines, -2 lines	0 comments	Download
M	src/cmd/gc/range.c	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/cmd/gc/runtime.go	View	1 2	1 chunk	+20 lines, -12 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1 2	10 chunks	+287 lines, -209 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 2	25 chunks	+59 lines, -267 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 2	16 chunks	+81 lines, -305 lines	0 comments	Download
A	src/pkg/math/fltasm_amd64.s	View		1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/iface.c	View	2	8 chunks	+142 lines, -90 lines	0 comments	Download
A	test/assign1.go	View	1 2	1 chunk	+343 lines, -0 lines	0 comments	Download
M	test/convert3.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug248.dir/bug3.go	View		2 chunks	+12 lines, -12 lines	0 comments	Download
M	test/fixedbugs/bug251.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug284.go	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	test/fixedbugs/bug285.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/golden.out	View		1 chunk	+0 lines, -55 lines	0 comments	Download
M	test/interface/explicit.go	View		1 chunk	+26 lines, -15 lines	0 comments	Download
M	test/interface/pointer.go	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	test/interface/receiver1.go	View		1 chunk	+37 lines, -28 lines	0 comments	Download
M	test/named.go	View		2 chunks	+237 lines, -237 lines	0 comments	Download
M	test/named1.go	View		1 chunk	+40 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-09 01:49:54 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=da7c1669ecbd *** gc: new typechecking rules * Code for assignment, conversions now ...

14 years, 9 months ago (2010-06-09 01:50:14 UTC) #2

lgtm

Expand All Messages | Collapse All Messages