Sandbox our Rhino runner so that we can run script under jsdoc.

Sandbox our Rhino runner so that we can run script under jsdoc.
http://codereview.appspot.com/130052

Sandboxed our JS runner using a variant of the scheme described at
http://codeutopia.net/blog/2009/01/02/sandboxing-rhino-in-java/ .
This will make it safer to run JSDoc as part of our build.

It's pretty much a straight implementation but I disallow acces
to all methods from Object.java except toString, and add some
explicit checks to make sure java.lang.reflect stuff doesn't
leak.

Then I changed existing test code to use powerboxes instead of
LiveConnect style Packages.java...

A lot of work was to get env.js to run.  I modified it, and locked
down how it can fetch URLs.  I added a <permissions> element to
build.xml to limit what our unittests can do with files.



Submitted @3823

[MikeSamuel, 2009-10-13 19:11:51]

http://codereview.appspot.com/130052/diff/95/1072
File src/com/google/caja/util/RhinoExecutor.java (right):

http://codereview.appspot.com/130052/diff/95/1072#newcode333
Line 333: getClass().getClassLoader().getResourceAsStream(path), "UTF-8");
I changed this to use the classloader instead of files, since the junit ant task
ignores permissions when running tests forked.

See
http://www.docjar.com/html/api/org/apache/tools/ant/taskdefs/optional/junit/J...
for the error message.

[MikeSamuel, 2009-10-20 00:57:28]

ping

[Jasvir, 2009-10-20 06:56:24]

A bit of a scary CL but I don't see any other way to sandbox rhino either.

LGTM

http://codereview.appspot.com/130052/diff/95/1072
File src/com/google/caja/util/RhinoExecutor.java (right):

http://codereview.appspot.com/130052/diff/95/1072#newcode122
Line 122: if (fullClassName.matches("[A-Z]")) {  // is a class, not a package
This regex misses some classes (eg jakarta regex) but its not fatal and probably
much quicker than the alternative.

[MikeSamuel, 2009-10-20 21:43:08]

http://codereview.appspot.com/130052/diff/95/1072
File src/com/google/caja/util/RhinoExecutor.java (right):

http://codereview.appspot.com/130052/diff/95/1072#newcode122
Line 122: if (fullClassName.matches("[A-Z]")) {  // is a class, not a package
On 2009/10/20 06:56:24, jasvir wrote:
> This regex misses some classes (eg jakarta regex) but its not fatal and
probably
> much quicker than the alternative.

Yep.  And a failure to distinguish a class from a package here only affects
logging, not whether something is allowed or not.