Add viewBox attribute to icons.

Add viewBox attribute to icons.

This branch adds the viewBox attribute to the default icons, as well as any icon being ingested (if it does not exist; https://code.launchpad.net/~makyo/juju-core/enable-viewboxing/+merge/180354 adds to the charm documentation the steps required to enable viewboxing from Inkscape).  This allows icons to be scaled within a viewport (such as an HTML img tag or an SVG image tag) rather than clipped in both FF and IE10.  This will only affect new charms, and some additional work will be required within the GUI to close this bug (https://bugs.launchpad.net/juju-gui/+bug/1207035)

https://code.launchpad.net/~makyo/charmworld/svg-viewbox/+merge/180400

(do not edit description out of merge proposal)

[matthew.scott, 2013-08-15 19:14:48]

Please take a look.

[benji, 2013-08-15 19:25:03]

Given reasonable answers to the small questions I had, this branch LGTM.

https://codereview.appspot.com/13001044/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/13001044/diff/1/charmworld/models.py#newcode929
charmworld/models.py:929: file_content = ElementTree.tostring(root,
encoding='UTF-8')
I don't think anyone regularly looks at the logs.  Do we instead want to reject
the icon if it doesn't have a viewbox or a height/width?

https://codereview.appspot.com/13001044/diff/1/charmworld/tests/test_models.py
File charmworld/tests/test_models.py (right):

https://codereview.appspot.com/13001044/diff/1/charmworld/tests/test_models.p...
charmworld/tests/test_models.py:1142: + '<svg height="10" viewBox="0 0 10 10"
width="10" />',
Why did you use a double quoted string with single-quoted attributes for the
first line and the opposite for the second?

You don't need the line continuation character ("\").

[bac, 2013-08-15 19:25:32]

LGTM -- it looks like there are one or more issues 'make lint' might find.

[matthew.scott, 2013-08-15 19:49:34]

Please take a look.