Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(595)

Issue 129700043: Create new auto_generated field in Messages and stop logging patchset deletions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by rmistry
Modified:
9 years, 8 months ago
Visibility:
Public.

Description

Create new auto_generated field in Messages. Set this field to True for Messages created for logging. Verified in the staging datastore that auto_generated is True for the following messages: * 'The CQ bit was (un)checked by...' from both the CQ checkbox and the 'LGTM and CQ'. * 'xyz changed reviewers:...' This CL also removes the patchset deletion logging as discussed in <a href='https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/M7f9VTqrR8w/RECOX2Y5YasJ'>https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/M7f9VTqrR8w/RECOX2Y5YasJ</a>

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M codereview/models.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M codereview/views.py View 6 chunks +8 lines, -14 lines 0 comments Download
M codereview/views_chromium.py View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rmistry
9 years, 8 months ago (2014-08-27 16:51:03 UTC) #1
jrobbins (corp)
lgtm
9 years, 8 months ago (2014-08-27 17:57:50 UTC) #2
rmistry
Submitted as https://code.google.com/p/rietveld/source/detail?r=ab90f5e6f8a44b54026ae214ee3ab19d3ff86d3e&name=chromium
9 years, 8 months ago (2014-08-27 18:12:35 UTC) #3
rmistry
9 years, 8 months ago (2014-08-27 18:15:09 UTC) #4
Message was sent while issue was closed.
On 2014/08/27 18:12:35, rmistry wrote:
> Submitted as
>
https://code.google.com/p/rietveld/source/detail?r=ab90f5e6f8a44b54026ae214ee...

Jason, please include this in your next push.
Also, you mentioned you were waiting for 'auto_generated' messages to fix the
case where reviewers are edited in and then the publish does not contain the
diff.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b