Issue 12960044: Fixes bogus complaints on IE10, FF Nightly, and Safari Nightly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12960044: Fixes bogus complaints on IE10, FF Nightly, and Safari Nightly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by MarkM

Modified:
12 years, 7 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The X_IGNORES_Y matrix of tests was not testing for seal violations correctly. The splice test was not creating a potential seal violation.

Patch Set 2 : Fixes bogus complaints on IE10, FF Nightly, and Safari Nightly #

Total comments: 2

Patch Set 3 : Fixes bogus complaints on IE10, FF Nightly, and Safari Nightly #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -17 lines)			Patch
	M	src/com/google/caja/ses/repairES5.js	View	1 2	4 chunks	+51 lines, -17 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

MarkM

The X_IGNORES_Y matrix of tests was not testing for seal violations correctly. The splice test ...

12 years, 7 months ago (2013-08-15 05:22:18 UTC) #2

kpreid2

LGTM https://codereview.appspot.com/12960044/diff/1002/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/12960044/diff/1002/src/com/google/caja/ses/repairES5.js#newcode3325 src/com/google/caja/ses/repairES5.js:3325: function test_METHOD_IGNORES_SEALED() { I don't like the use ...

12 years, 7 months ago (2013-08-15 16:43:11 UTC) #3

MarkM

The X_IGNORES_Y matrix of tests was not testing for seal violations correctly. The splice test ...

12 years, 7 months ago (2013-08-15 17:02:31 UTC) #4

MarkM

12 years, 7 months ago (2013-08-15 17:02:57 UTC) #5

https://codereview.appspot.com/12960044/diff/1002/src/com/google/caja/ses/rep...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/12960044/diff/1002/src/com/google/caja/ses/rep...
src/com/google/caja/ses/repairES5.js:3325: function test_METHOD_IGNORES_SEALED()
{
On 2013/08/15 16:43:11, kpreid2 wrote:
> I don't like the use of uppercase here because it implies that
> 'METHOD_IGNORES_SEALED' is an actual problem ID. I suggest either
> 'test_method_IGNORES_SEALED' or keeping the original name. Ditto for the other
> test and the repair.
> 
> I suggest inserting a comment above this line explaining what the difference
> between the two test functions is.

Done.

Expand All Messages | Collapse All Messages