Implement IME state per window.

Implement IME state per window.


BUG=http://code.google.com/p/ibus/issues/detail?id=1568
TEST=Disable global engine with ibus-setup.

[Peng, 2013-08-23 17:55:56]

https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h
File bus/panelproxy.h (right):

https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h#newcode58
bus/panelproxy.h:58: *connection);
This wrapped line looks not nice.
Could you please move '(' forward a lit bit, to make it fit in one line?

For example:

return_type  *function_name  (BusConnection *connection);
return_type  *function__very_long_name
                             (BusConnection *connection);

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode463
ui/gtk3/panel.vala:463: private void set_engine(IBus.EngineDesc engine) {
Should we check if the engine has been disabled?

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode509
ui/gtk3/panel.vala:509: /* m_switcher changes m_current_context_path */
The comment is not very clear.

[fujiwara, 2013-08-26 16:48:41]

https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h
File bus/panelproxy.h (right):

https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h#newcode58
bus/panelproxy.h:58: *connection);
On 2013/08/23 17:55:56, Peng wrote:
> This wrapped line looks not nice.
> Could you please move '(' forward a lit bit, to make it fit in one line?
> 
> For example:
> 
> return_type  *function_name  (BusConnection *connection);
> return_type  *function__very_long_name
>                              (BusConnection *connection);

Done.

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode463
ui/gtk3/panel.vala:463: private void set_engine(IBus.EngineDesc engine) {
On 2013/08/23 17:55:56, Peng wrote:
> Should we check if the engine has been disabled?

Done.

https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode509
ui/gtk3/panel.vala:509: /* m_switcher changes m_current_context_path */
On 2013/08/23 17:55:56, Peng wrote:
> The comment is not very clear.

Done.

[Peng, 2013-08-26 17:52:44]

On 2013/08/26 16:48:41, fujiwara wrote:
> https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h
> File bus/panelproxy.h (right):
> 
> https://codereview.appspot.com/12957046/diff/4001/bus/panelproxy.h#newcode58
> bus/panelproxy.h:58: *connection);
> On 2013/08/23 17:55:56, Peng wrote:
> > This wrapped line looks not nice.
> > Could you please move '(' forward a lit bit, to make it fit in one line?
> > 
> > For example:
> > 
> > return_type  *function_name  (BusConnection *connection);
> > return_type  *function__very_long_name
> >                              (BusConnection *connection);
> 
> Done.
> 
> https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala
> File ui/gtk3/panel.vala (right):
> 
>
https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode463
> ui/gtk3/panel.vala:463: private void set_engine(IBus.EngineDesc engine) {
> On 2013/08/23 17:55:56, Peng wrote:
> > Should we check if the engine has been disabled?
> 
> Done.
> 
>
https://codereview.appspot.com/12957046/diff/4001/ui/gtk3/panel.vala#newcode509
> ui/gtk3/panel.vala:509: /* m_switcher changes m_current_context_path */
> On 2013/08/23 17:55:56, Peng wrote:
> > The comment is not very clear.
> 
> Done.

[Peng, 2013-08-27 13:17:12]

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode463
ui/gtk3/panel.vala:463: private void set_engine(IBus.EngineDesc engine, bool
in_engines) {
Is the arg in_engines necessary? Maybe it is better to check the engine outside
of this function?

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode762
ui/gtk3/panel.vala:762: if (engine == null) {
If engine is null, I think you don't need set engine to m_engines[0], because
current engine is the first one. right?

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode771
ui/gtk3/panel.vala:771: set_engine(engine, in_engines);
I think it is better to check the engine is in m_engines here, and then call
set_engine.

[fujiwara, 2013-08-28 01:04:19]

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode463
ui/gtk3/panel.vala:463: private void set_engine(IBus.EngineDesc engine, bool
in_engines) {
On 2013/08/27 13:17:13, Peng wrote:
> Is the arg in_engines necessary? Maybe it is better to check the engine
outside
> of this function?

Done.

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode762
ui/gtk3/panel.vala:762: if (engine == null) {
On 2013/08/27 13:17:13, Peng wrote:
> If engine is null, I think you don't need set engine to m_engines[0], because
> current engine is the first one. right?

No, current engine is not.
I added the comment.

https://codereview.appspot.com/12957046/diff/11001/ui/gtk3/panel.vala#newcode771
ui/gtk3/panel.vala:771: set_engine(engine, in_engines);
On 2013/08/27 13:17:13, Peng wrote:
> I think it is better to check the engine is in m_engines here, and then call
> set_engine.

Done.

[Peng, 2013-08-28 02:46:15]

lgtm