Moved the definition of max-token length from preprocessor to compiler.

Moved the definition of max-token length from preprocessor to compiler.

R=kbr@chromium.org

Committed: https://code.google.com/p/angleproject/source/detail?r=ba2cfe7

[kbr1, 2013-08-14 23:08:43]

LGTM with the following caveat.

https://codereview.appspot.com/12957043/diff/1/src/compiler/glslang.y
File src/compiler/glslang.y (right):

https://codereview.appspot.com/12957043/diff/1/src/compiler/glslang.y#newcode54
src/compiler/glslang.y:54: #define SH_MAX_TOKEN_LENGTH 256  // WebGL spec.
Not sure whether it's appropriate to tie the shader translator in general to
this WebGL-specific restriction. Having it be configurable seems fine though.

[Alok Priyadarshi, 2013-08-14 23:12:14]

https://codereview.appspot.com/12957043/diff/1/src/compiler/glslang.y
File src/compiler/glslang.y (right):

https://codereview.appspot.com/12957043/diff/1/src/compiler/glslang.y#newcode54
src/compiler/glslang.y:54: #define SH_MAX_TOKEN_LENGTH 256  // WebGL spec.
On 2013/08/14 23:08:43, kbr1 wrote:
> Not sure whether it's appropriate to tie the shader translator in general to
> this WebGL-specific restriction. Having it be configurable seems fine though.

We might want to move it to the shader compiler API eventually. For now I am
just moving it from the preprocessor to compiler. I need it to refactor
something else.

[Alok Priyadarshi, 2013-08-14 23:58:06]

Committed patchset #1 manually as rba2cfe7 (presubmit successful).