Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 12937045: ANGLE streaming buffer instanced drawing overflow (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by Jamie Madill
Modified:
11 years, 11 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject/@es3proto
Visibility:
Public.

Description

ANGLE streaming buffer instanced drawing overflow When performing and instanced draw from the streaming buffer, we would at times copy the number of vertices of the draw call instead of the number of vertices in the instanced draw. BUG=467

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better comments, handle buffer out-of-bounds, fixed divisor counting #

Patch Set 3 : Updated comment, remove unnecessary check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/libGLESv2/Buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/Buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/renderer/VertexDataManager.cpp View 1 2 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Geoff Lang
LGTM as long as the tabs are fixed. https://codereview.appspot.com/12937045/diff/1/src/libGLESv2/renderer/VertexDataManager.cpp File src/libGLESv2/renderer/VertexDataManager.cpp (right): https://codereview.appspot.com/12937045/diff/1/src/libGLESv2/renderer/VertexDataManager.cpp#newcode50 src/libGLESv2/renderer/VertexDataManager.cpp:50: return ...
11 years, 12 months ago (2013-08-26 14:49:12 UTC) #1
Shannon Woods
The buffer and vertex data management code is a little dense to get through-- I ...
11 years, 12 months ago (2013-08-26 15:26:32 UTC) #2
Shannon Woods
LGTM -- the comments help a lot, thank you. It'd be a bonus if you ...
11 years, 12 months ago (2013-08-26 18:56:16 UTC) #3
Shannon Woods
11 years, 12 months ago (2013-08-26 19:14:10 UTC) #4
patchset 3 also LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b