Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 129310044: oauth2: Rename exchange code to authorization code

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by jbd
Modified:
11 years, 4 months ago
Reviewers:
adg, bradfitz
CC:
golang-codereviews
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M example_test.go View 1 chunk +6 lines, -6 lines 0 comments Download
M oauth2.go View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5
jbd
Spec talks about an authorization code, not an exchange code.
11 years, 4 months ago (2014-08-17 02:32:31 UTC) #1
bradfitz
https://codereview.appspot.com/129310044/diff/1/example_test.go File example_test.go (right): https://codereview.appspot.com/129310044/diff/1/example_test.go#newcode38 example_test.go:38: var authorizationCode string these are fine since they're just ...
11 years, 4 months ago (2014-08-17 03:48:32 UTC) #2
jbd
https://codereview.appspot.com/129310044/diff/1/example_test.go File example_test.go (right): https://codereview.appspot.com/129310044/diff/1/example_test.go#newcode38 example_test.go:38: var authorizationCode string On 2014/08/17 03:48:32, bradfitz wrote: > ...
11 years, 4 months ago (2014-08-17 04:22:45 UTC) #3
bradfitz
LGTM
11 years, 4 months ago (2014-08-17 04:29:15 UTC) #4
jbd
11 years, 4 months ago (2014-08-17 05:32:35 UTC) #5
Submitted as 3a5e8819eb8f6d714a50f2290b6ef7c4c09eac5a.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b