lgtm https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... src/com/google/caja/plugin/domado.js:1435: * clearInterval that only allow simple functions as timeouts and fix comment? https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... src/com/google/caja/plugin/domado.js:7035: function (code) { // no time arg I'd rather the function signature match, like maybe function (code, ignore) https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/t... File tests/com/google/caja/plugin/test-domado-events-guest.html (right): https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/t... tests/com/google/caja/plugin/test-domado-events-guest.html:467: function testRequestAnimationFrame() { this test might fail when the test browser is in the background, since the browser doesn't have to generate animation events when the window isn't visible. that isn't likely to happen in any normal test setup, but maybe add a comment?
Fixes <https://code.google.com/p/google-caja/issues/detail?id=1741>.
new snapshot https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... src/com/google/caja/plugin/domado.js:1435: * clearInterval that only allow simple functions as timeouts and On 2013/08/19 22:18:11, felix8a wrote: > fix comment? Rewrote comment. https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/dom... src/com/google/caja/plugin/domado.js:7035: function (code) { // no time arg On 2013/08/19 22:18:11, felix8a wrote: > I'd rather the function signature match, like maybe > function (code, ignore) Done. https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/t... File tests/com/google/caja/plugin/test-domado-events-guest.html (right): https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/t... tests/com/google/caja/plugin/test-domado-events-guest.html:467: function testRequestAnimationFrame() { On 2013/08/19 22:18:11, felix8a wrote: > this test might fail when the test browser is in the background, since the > browser doesn't have to generate animation events when the window isn't visible. > that isn't likely to happen in any normal test setup, but maybe add a comment? Actually, in manual testing if I open a bunch of tests in tabs... Changed to schedule entirely inside of its own rAF calls; now the test is independent of the rate of time passing. I was originally trying to avoid the test neither passing nor failing, but I now think this is better.
lgtm