Issue 12906044: state;charm: Refactor state/Endpoint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12906044: state;charm: Refactor state/Endpoint (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dimitern

Modified:
10 years, 9 months ago

Reviewers:
jameinel, mp+180141, rog

Visibility:
Public.

Description

state;charm: Refactor state/Endpoint Two methods of state.Endpoint are not related to state, more to charm metadata. Endpoint embeds a charm.Relation, so I moved IsImplicit() and ImplementedBy() from Endpoint to charm.Relation, along with their tests. This is necessary, so that we can avoid implementing API calls for them in the uniter API facade, becasue the uniter needs them. https://code.launchpad.net/~dimitern/juju-core/102-state-endpoint-refactoring/+merge/180141 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state;charm: Refactor state/Endpoint #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -122 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/meta.go	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	charm/meta_test.go	View		1 chunk	+78 lines, -0 lines	0 comments	Download
M	state/endpoint.go	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
M	state/endpoint_test.go	View		1 chunk	+0 lines, -81 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jameinel

This just moves the functions to charm.Relation which has all the information we were operating ...

10 years, 9 months ago (2013-08-14 14:07:05 UTC) #3

LGTM

Expand All Messages | Collapse All Messages