Issue 129060: Changes to core code required by the linter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 129060: Changes to core code required by the linter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by MikeSamuel

Modified:
16 years, 7 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Most of the changes are to JS files to fix linty nits. But the linter makes heavy use in places of sparse bit sets, so there are some additions to those. Submitted @3803

Patch Set 1 #

Patch Set 2 : Changes to core code required by the linter. #

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+333 lines, -108 lines)			Patch
M	src/com/google/caja/cajita.js	View	1	5 chunks	+11 lines, -10 lines	0 comments	Download
M	src/com/google/caja/cajita-debugmode.js	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/com/google/caja/lang/css/CssPropertyPatterns.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/lang/html/HtmlDefinitions.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/AncestorChain.java	View	1	3 chunks	+34 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/CaseStmt.java	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/DefaultCaseStmt.java	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FinallyStmt.java	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ForEachLoop.java	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/LabeledStatement.java	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/LabeledStmtWrapper.java	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Loop.java	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Parser.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/SwitchStmt.java	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ThrowStmt.java	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
MM	src/com/google/caja/plugin/bridal.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/domita.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/html-emitter.js	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/unicode.js	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/reporting/MessageType.java	View	1	4 chunks	+12 lines, -79 lines	0 comments	Download
M	src/com/google/caja/reporting/SnippetProducer.java	View	1	3 chunks	+54 lines, -5 lines	0 comments	Download
M	src/com/google/caja/util/Sets.java	View	1	1 chunk	+30 lines, -1 line	0 comments	Download
M	src/com/google/caja/util/SparseBitSet.java	View	1	3 chunks	+92 lines, -0 lines	0 comments	Download
M	src/com/google/caja/valija-cajita.js	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/MatchExperiments.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/util/SparseBitSetTest.java	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages