Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 129044: Fix a couple of build problems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by ihab.awad
Modified:
16 years, 8 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. Fix r3784 where the additional 3pty jars were not being copied into ant-libs/ by the build file. 2. Fix the following issue: http://code.google.com/p/google-caja/issues/detail?id=1134 by changing the default PluginEnvironment of the build service to rewrite URIs to point to "example.com", which is an RFC-reserved domain that will never resolve to anything.

Patch Set 1 #

Patch Set 2 : Fix a couple of build problems #

Patch Set 3 : Fix a couple of build problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M build.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/BuildServiceImplementation.java View 1 chunk +3 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ihab.awad
16 years, 8 months ago (2009-10-07 20:02:09 UTC) #1
ihab.awad
16 years, 8 months ago (2009-10-07 20:02:16 UTC) #2
MikeSamuel
LGTM
16 years, 8 months ago (2009-10-07 20:03:40 UTC) #3
ihab.awad
16 years, 8 months ago (2009-10-07 20:06:12 UTC) #4
ihab.awad
16 years, 8 months ago (2009-10-07 20:14:12 UTC) #5
@3786
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b