Updated/simplified to use options.formatters and options.predicates

[sroussey, 2009-10-07 01:46:59]

Update to make the PHP and JS versions both have the same API, using
options.formatters[] and options.predicates[]

http://codereview.appspot.com/129041/diff/1/2
File javascript/json-template.js (right):

http://codereview.appspot.com/129041/diff/1/2#newcode56
Line 56: };
Moved to top so I could use Template.formatters={... so it can be more easily be
manipulated by a subclass, for example

http://codereview.appspot.com/129041/diff/1/2#newcode91
Line 91: Template.formatters = {
Simpler way that can be overridden, unlike DEFAULT_FORMATTERS

http://codereview.appspot.com/129041/diff/1/2#newcode157
Line 157: new_context= null;
I have push() always push. Push and pop will thus always match

http://codereview.appspot.com/129041/diff/1/2#newcode313
Line 313: do_section = f[0](predicate_target_value,context,f[1]);
predicates always get three params (data, context, args). JS doesn't care about
extras. JSLint might.

http://codereview.appspot.com/129041/diff/1/2#newcode478
Line 478: };
I think this is an optimization -- not recreating on each loop below. Depends on
the implementation of JS, which most tend not to optimize this type of stuff
(even though most compilers do).

http://codereview.appspot.com/129041/diff/1/2#newcode519
Line 519: var repeated = !!section_match[1];
This forces a typecast to bool, useful in the log messages.

[andychu, 2009-10-07 02:49:54]

These diffs are too big for me to review all at once.  There are lots of
separate changes within one diff.  Can you split them up, ideally in order of
least discussion required -> most discussion required.

thanks,
Andy

http://codereview.appspot.com/129041/diff/1/2
File javascript/json-template.js (right):

http://codereview.appspot.com/129041/diff/1/2#newcode96
Line 96: 'attr': function(s) {
this name can't be changed incompatibly

http://codereview.appspot.com/129041/diff/1/2#newcode157
Line 157: new_context= null;
On 2009/10/07 01:47:00, sroussey wrote:
> I have push() always push. Push and pop will thus always match

Why would this be necessary?  Also may be a compatibility problem.

http://codereview.appspot.com/129041/diff/1/2#newcode478
Line 478: };
On 2009/10/07 01:47:00, sroussey wrote:
> I think this is an optimization -- not recreating on each loop below. Depends
on
> the implementation of JS, which most tend not to optimize this type of stuff
> (even though most compilers do).

OK, this is probably good.  But it should be split out into separate changes.