Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 12899043: simplify css whitelist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by felix8a
Modified:
12 years, 6 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Our css rules try to make a distinction between pure css21 and css-extensions, but in practice nobody wants to limit to css21, and the separation makes it hard to audit the rules. This CL eliminates the distinction between css21 and css-extensions, so that there's only a single set of rules. I have some more changes in mind, but this is a prerequisite, so I'm trying to keep this change relatively simple. The diff is unfortunately hard to audit, but it's mostly just combining the css21 and css-extensions rules, re-alphabetizing, and removing the duplicates (which are css21 rules superseded by css-extension rules) So some of these rules are not quite what the css3 specs say. Later, I'll fix up individual rules to conform to css3 reality.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -2192 lines) Patch
M build.xml View 1 chunk +6 lines, -10 lines 0 comments Download
M src/com/google/caja/lang/css/CssSchema.java View 1 chunk +2 lines, -2 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions.json View 1 chunk +0 lines, -13 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions-defs.json View 1 chunk +0 lines, -741 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions-fns.json View 1 chunk +0 lines, -5 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions-fns-defs.json View 1 chunk +0 lines, -6 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions-fns-whitelist.json View 1 chunk +0 lines, -4 lines 0 comments Download
D src/com/google/caja/lang/css/css-extensions-whitelist.json View 1 chunk +0 lines, -56 lines 0 comments Download
D src/com/google/caja/lang/css/css21.json View 1 chunk +0 lines, -13 lines 0 comments Download
D src/com/google/caja/lang/css/css21-defs.json View 1 chunk +0 lines, -961 lines 0 comments Download
D src/com/google/caja/lang/css/css21-fns.json View 1 chunk +0 lines, -3 lines 0 comments Download
D src/com/google/caja/lang/css/css21-fns-defs.json View 1 chunk +0 lines, -15 lines 0 comments Download
D src/com/google/caja/lang/css/css21-fns-whitelist.json View 1 chunk +0 lines, -9 lines 0 comments Download
D src/com/google/caja/lang/css/css21-whitelist.json View 1 chunk +0 lines, -123 lines 0 comments Download
A + src/com/google/caja/lang/css/css3.json View 1 chunk +3 lines, -11 lines 0 comments Download
A + src/com/google/caja/lang/css/css3-defs.json View 41 chunks +796 lines, -180 lines 1 comment Download
A + src/com/google/caja/lang/css/css3-fns.json View 1 chunk +3 lines, -1 line 0 comments Download
A + src/com/google/caja/lang/css/css3-fns-defs.json View 1 chunk +21 lines, -7 lines 0 comments Download
A + src/com/google/caja/lang/css/css3-fns-whitelist.json View 1 chunk +13 lines, -5 lines 0 comments Download
A + src/com/google/caja/lang/css/css3-whitelist.json View 2 chunks +73 lines, -27 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 7 months ago (2013-08-13 22:08:33 UTC) #1
MikeSamuel
LGTM https://codereview.appspot.com/12899043/diff/1/src/com/google/caja/lang/css/css3-defs.json File src/com/google/caja/lang/css/css3-defs.json (left): https://codereview.appspot.com/12899043/diff/1/src/com/google/caja/lang/css/css3-defs.json#oldcode60 src/com/google/caja/lang/css/css3-defs.json:60: { "key": "background", Ok, this was subsmued by ...
12 years, 7 months ago (2013-08-16 04:18:56 UTC) #2
felix8a
12 years, 6 months ago (2013-08-19 22:40:25 UTC) #3
@r5565
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b