Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3565)

Issue 12891043: Fixed error message for exceeding maximum struct nesting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Alok Priyadarshi
Modified:
10 years, 8 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject@master
Visibility:
Public.

Description

Fixed error message for exceeding maximum struct nesting. It got broken in r2423. We were referring to field-name as struct-name. This patch fixes the regression and also improves the error message by adding the field-name. BUG=459 R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=e06002a

Patch Set 1 #

Patch Set 2 : reverted unnecessary edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1602 lines, -1600 lines) Patch
M src/compiler/ParseHelper.cpp View 1 1 chunk +1602 lines, -1600 lines 0 comments Download

Messages

Total messages: 6
Alok Priyadarshi
10 years, 8 months ago (2013-08-13 20:56:59 UTC) #1
kbr1
LGTM I don't suppose it's possible to add a test for this?
10 years, 8 months ago (2013-08-13 20:57:57 UTC) #2
Alok Priyadarshi
On 2013/08/13 20:57:57, kbr1 wrote: > LGTM > > I don't suppose it's possible to ...
10 years, 8 months ago (2013-08-13 21:01:41 UTC) #3
kbr1
It isn't feasible to require anything in the error messages at the WebGL level, but ...
10 years, 8 months ago (2013-08-13 21:04:04 UTC) #4
Alok Priyadarshi
On 2013/08/13 21:04:04, kbr1 wrote: > It isn't feasible to require anything in the error ...
10 years, 8 months ago (2013-08-13 21:32:03 UTC) #5
Alok Priyadarshi
10 years, 8 months ago (2013-08-13 21:35:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as re06002a (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b