Issue 12876043: Print token string into the syntax error message.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12876043: Print token string into the syntax error message. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Alok Priyadarshi

Modified:
10 years, 8 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject@master

Visibility:
Public.

More Reviews

Description

Print token string into the syntax error message. Bison calls yyerror("syntax error") when it cannot match any grammar rule. We used to append current token string to the error message, which got broken in r2202. This patch restores the original behavior. BUG=442 R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=686eb7d

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	src/compiler/glslang.l	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/glslang.y	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

LGTM Is it worth backporting this fix to any earlier branches?

10 years, 8 months ago (2013-08-13 18:02:27 UTC) #2

Alok Priyadarshi

On 2013/08/13 18:02:27, kbr1 wrote: > LGTM > > Is it worth backporting this fix ...

10 years, 8 months ago (2013-08-13 18:08:16 UTC) #3

Alok Priyadarshi

10 years, 8 months ago (2013-08-13 18:11:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r686eb7d (presubmit successful).

Expand All Messages | Collapse All Messages