Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1566)

Issue 12872043: utils/set: use value methods consistently

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rog
Modified:
10 years, 9 months ago
Reviewers:
dimitern, natefinch, mp+179966
Visibility:
Public.

Description

utils/set: use value methods consistently This means we can build up expressions with sets; for instance s1.Union(s2).Union(s2), something that did not work before. Only methods that modify the set in place remain pointer methods, as is conventional. Another possibility would be to pass *set.Strings around for everything. https://code.launchpad.net/~rogpeppe/juju-core/366-set-value-methods/+merge/179966 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : utils/set: use value methods consistently #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M utils/set/strings.go View 1 6 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 9 months ago (2013-08-13 17:34:06 UTC) #1
natefinch
LGTM
10 years, 9 months ago (2013-08-13 17:40:18 UTC) #2
dimitern
10 years, 9 months ago (2013-08-13 18:43:42 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b