Issue 12865044: Ignore files generated by GYP.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12865044: Ignore files generated by GYP. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by Alok Priyadarshi

Modified:
11 years, 3 months ago

Reviewers:
shannonwoods1, Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject@master

Visibility:
Public.

Ignore files generated by GYP. R=shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=b0c3137

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	.gitignore	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7

Shannon Woods

On 2013/08/13 17:59:57, Alok Priyadarshi wrote: Those are our build files. We kind of need ...

11 years, 3 months ago (2013-08-13 18:58:54 UTC) #3

Alok Priyadarshi

On 2013/08/13 18:58:54, shannonwoods wrote: > On 2013/08/13 17:59:57, Alok Priyadarshi wrote: > > Those ...

11 years, 3 months ago (2013-08-13 20:17:59 UTC) #4

Shannon Woods

On 2013/08/13 21:49:00, Alok Priyadarshi wrote: > Now ignoring only auto-generated files. LGTM. Thank you!

11 years, 3 months ago (2013-08-13 22:06:32 UTC) #6

Alok Priyadarshi

11 years, 3 months ago (2013-08-13 22:09:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as rb0c3137 (presubmit successful).