Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1521)

Issue 12865044: Ignore files generated by GYP. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Alok Priyadarshi
Modified:
10 years, 7 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject@master
Visibility:
Public.

Description

Ignore files generated by GYP. R=shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=b0c3137

Patch Set 1 #

Patch Set 2 : only ignore gyp-generated files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Alok Priyadarshi
10 years, 7 months ago (2013-08-13 16:45:09 UTC) #1
Alok Priyadarshi
10 years, 7 months ago (2013-08-13 17:59:57 UTC) #2
Shannon Woods
On 2013/08/13 17:59:57, Alok Priyadarshi wrote: Those are our build files. We kind of need ...
10 years, 7 months ago (2013-08-13 18:58:54 UTC) #3
Alok Priyadarshi
On 2013/08/13 18:58:54, shannonwoods wrote: > On 2013/08/13 17:59:57, Alok Priyadarshi wrote: > > Those ...
10 years, 7 months ago (2013-08-13 20:17:59 UTC) #4
Alok Priyadarshi
Now ignoring only auto-generated files.
10 years, 7 months ago (2013-08-13 21:49:00 UTC) #5
Shannon Woods
On 2013/08/13 21:49:00, Alok Priyadarshi wrote: > Now ignoring only auto-generated files. LGTM. Thank you!
10 years, 7 months ago (2013-08-13 22:06:32 UTC) #6
Alok Priyadarshi
10 years, 7 months ago (2013-08-13 22:09:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as rb0c3137 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b