Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 12865043: Add document.getElementsByName. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by kpreid2
Modified:
12 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes <https://code.google.com/p/google-caja/issues/detail?id=1790>. Note: Some of the jQuery pass count changes should have been attributed to previous revisions, including the regression in jQuery 'dimensions' on Firefox. @r5556

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add document.getElementsByName. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 2 chunks +15 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-scan-guest.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/third-party-tests.json View 1 4 chunks +10 lines, -6 lines 2 comments Download

Messages

Total messages: 7
kpreid2
12 years, 7 months ago (2013-08-13 16:26:46 UTC) #1
felix8a
https://codereview.appspot.com/12865043/diff/1/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html File tests/com/google/caja/plugin/es53-test-domado-dom-guest.html (right): https://codereview.appspot.com/12865043/diff/1/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html#newcode942 tests/com/google/caja/plugin/es53-test-domado-dom-guest.html:942: <input id="testGetElementsByName-1" name="testGetElementsByName-name"> how about add some special chars ...
12 years, 7 months ago (2013-08-13 16:50:52 UTC) #2
kpreid2
Fixes <https://code.google.com/p/google-caja/issues/detail?id=1790>. Note: Some of the jQuery pass count changes should have been attributed to ...
12 years, 7 months ago (2013-08-13 19:12:32 UTC) #3
kpreid2
https://codereview.appspot.com/12865043/diff/1/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html File tests/com/google/caja/plugin/es53-test-domado-dom-guest.html (right): https://codereview.appspot.com/12865043/diff/1/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html#newcode942 tests/com/google/caja/plugin/es53-test-domado-dom-guest.html:942: <input id="testGetElementsByName-1" name="testGetElementsByName-name"> On 2013/08/13 16:50:52, felix8a wrote: > ...
12 years, 7 months ago (2013-08-13 19:13:01 UTC) #4
felix8a
lgtm
12 years, 7 months ago (2013-08-13 19:36:54 UTC) #5
felix8a
https://codereview.appspot.com/12865043/diff/6001/tests/com/google/caja/plugin/third-party-tests.json File tests/com/google/caja/plugin/third-party-tests.json (right): https://codereview.appspot.com/12865043/diff/6001/tests/com/google/caja/plugin/third-party-tests.json#newcode163 tests/com/google/caja/plugin/third-party-tests.json:163: "expected-pass": { "firefox": 131, "chrome": 141 } sorry, I ...
12 years, 7 months ago (2013-08-13 22:35:42 UTC) #6
kpreid2
12 years, 7 months ago (2013-08-13 22:40:00 UTC) #7
Message was sent while issue was closed.
https://codereview.appspot.com/12865043/diff/6001/tests/com/google/caja/plugi...
File tests/com/google/caja/plugin/third-party-tests.json (right):

https://codereview.appspot.com/12865043/diff/6001/tests/com/google/caja/plugi...
tests/com/google/caja/plugin/third-party-tests.json:163: "expected-pass": {
"firefox": 131, "chrome": 141 }
On 2013/08/13 22:35:42, felix8a wrote:
> sorry, I missed this problem. missing comma here. (causes testing to abort)

Sorry, should have tested for that. @r5557.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b