Simplified content sanitizer.

[awiner, 2009-01-30 21:30:53]

http://codereview.appspot.com/12861/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java
(right):

http://codereview.appspot.com/12861/diff/1/5#newcode37
Line 37: @ImplementedBy(NekoHtmlParser.class)
is this change intended globally?  Since sanitization requires the
"non-simplified" parser, it'd potentially be useful to introduce a
GadgetHtmlParserFactory API w/getHtmlParser(Gadget gadget).  That API would be
useful as well for text/os-data data pipelining.

http://codereview.appspot.com/12861/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/ParseModule.java
(right):

http://codereview.appspot.com/12861/diff/1/4#newcode38
Line 38: bind(GadgetHtmlParser.class).to(NekoHtmlParser.class);
ditto

http://codereview.appspot.com/12861/diff/1/6
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriter.java
(right):

http://codereview.appspot.com/12861/diff/1/6#newcode134
Line 134: private static List<Attr> toList(NamedNodeMap nodes) {
move to DomUtils?  Should return Iterable<Attr>, not List (it'd be more
efficient as an adapter than a copy, not that it needs to be written that way at
the moment)

http://codereview.appspot.com/12861/diff/1/6#newcode144
Line 144: /** Convert a NamedNodeMap to a list for easy and safe operations */
s/NamedNodeMap/NodeList

http://codereview.appspot.com/12861/diff/1/6#newcode145
Line 145: private static List<Node> toList(NodeList nodes) {
Move to DomUtils?  Also should be Iterable<Node>

http://codereview.appspot.com/12861/diff/1/6#newcode162
Line 162: public @interface AllowedTags { }
move at or near the top

http://codereview.appspot.com/12861/diff/1/2
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriterTest.java
(right):

http://codereview.appspot.com/12861/diff/1/2#newcode153
Line 153: "element", ImmutableSet.<String>of("href", "src"));
<String> unneeded