Issue 12850044: apiserver/uniter: State charm operations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12850044: apiserver/uniter: State charm operations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
gz, mp+179924, rog

Visibility:
Public.

Description

apiserver/uniter: State charm operations This implements the needed state.Charm server-side uniter API operations: * CharmBundleURL * CharmBundleSha256 https://code.launchpad.net/~dimitern/juju-core/100-apiserver-uniter-charm-ops/+merge/179924 Requires: https://code.launchpad.net/~dimitern/juju-core/099-apiserver-uniter-service-ops/+merge/179886 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : apiserver/uniter: State charm operations #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/internal.go	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View	1	2 chunks	+58 lines, -8 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM with one trivial suggestion below. https://codereview.appspot.com/12850044/diff/1/state/apiserver/uniter/uniter.go File state/apiserver/uniter/uniter.go (right): https://codereview.appspot.com/12850044/diff/1/state/apiserver/uniter/uniter.go#newcode572 state/apiserver/uniter/uniter.go:572: // CharmBundleURL returns ...

10 years, 8 months ago (2013-08-13 14:32:01 UTC) #2

LGTM with comment fix. https://codereview.appspot.com/12850044/diff/1/state/api/params/internal.go File state/api/params/internal.go (right): https://codereview.appspot.com/12850044/diff/1/state/api/params/internal.go#newcode43 state/api/params/internal.go:43: // StringResult holds a string ...

10 years, 8 months ago (2013-08-13 14:56:40 UTC) #3

dimitern

10 years, 8 months ago (2013-08-13 15:15:58 UTC) #4

Please take a look.

https://codereview.appspot.com/12850044/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12850044/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:43: // StringResult holds a string or a string.
On 2013/08/13 14:56:40, gz wrote:
> Er...?

:) Fixed.

https://codereview.appspot.com/12850044/diff/1/state/apiserver/uniter/uniter.go
File state/apiserver/uniter/uniter.go (right):

https://codereview.appspot.com/12850044/diff/1/state/apiserver/uniter/uniter....
state/apiserver/uniter/uniter.go:572: // CharmBundleURL returns the SHA256
digest, corresponding to the
On 2013/08/13 14:32:01, rog wrote:
> // CharmBundleURL returns the SHA256 digest of the
> // charm bundle data for each charm url in the
> // given parameters.
> 
> ?

Done.

Expand All Messages | Collapse All Messages