Issue 128460044: Remove the nested heap API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 128460044: Remove the nested heap API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by Sébastien Marchand

Modified:
11 years, 4 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove the nested heap API. This isn't currently used and it isn't compatible with the new design, we'll reimplement this if needed. BUG= R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2265

Patch Set 1 #

Patch Set 2 : Remove the nested heap imports from unittest_util.h #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -300 lines)			Patch
M	syzygy/agent/asan/asan.gyp	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	syzygy/agent/asan/asan_rtl_unittest.cc	View	1	2 chunks	+1 line, -11 lines	0 comments	Download
D	syzygy/agent/asan/nested_heap.h	View		1 chunk	+0 lines, -106 lines	0 comments	Download
D	syzygy/agent/asan/nested_heap.cc	View		1 chunk	+0 lines, -121 lines	0 comments	Download
M	syzygy/agent/asan/syzyasan_rtl.def	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	syzygy/agent/asan/unittest_util.h	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download
M	syzygy/build/README.TXT.template	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	syzygy/build/all.gyp	View		2 chunks	+2 lines, -20 lines	0 comments	Download
M	syzygy/build/get_syzygy_binaries.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sébastien Marchand

11 years, 4 months ago (2014-08-20 14:46:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 2265 (presubmit successful).

Expand All Messages | Collapse All Messages