trill-pitch-engraver: acknowledge stems and flags; issue 3465

trill-pitch-engraver: acknowledge stems and flags; issue 3465

[janek, 2013-08-14 11:55:37]

LGTM.

[dak, 2013-08-14 12:03:39]

I'm in a rush right now so can't test.  But would that even help with whole
notes and breves?

[janek, 2013-08-14 12:21:39]

2013/8/14  <dak@gnu.org>:
> I'm in a rush right now so can't test.  But would that even help with
> whole notes and breves?

Good point.  But i think that this can be added anyway, as it makes
sense in itself.

[Keith, 2013-08-14 20:50:27]

On Wed, 14 Aug 2013 05:03:40 -0700, <dak@gnu.org> wrote:

> I'm in a rush right now so can't test.  But would that even help with
> whole notes and breves?

... or a down-stem note with a pitched trill more than a third above.

If there is room to move the small note over the main note, this patch allows
the small note to go there.  For normal trills, with an interval less than a
third, the main notehead forces the second note to the right.

I'll suggest on the tracker a minimum X-offset, so that the small note doesn't
move completely over the main note-column, in the rare cases where there is
room.

>
> https://codereview.appspot.com/12844043/

[janek, 2013-08-18 11:00:46]

still LGTM.
And i found a bug in side-position-interface during testing!

Janek