Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 12841044: state: RelationUnit.PrepareLeaveScope

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by fwereade
Modified:
9 years, 10 months ago
Reviewers:
mp+181065, wallyworld, gz
Visibility:
Public.

Description

state: RelationUnit.PrepareLeaveScope Added a mechanism whereby units can report imminent departure from a relation, such that related ones see them disappear immediately and reconfigure to ignore them *before* they actually disappear for good. Exactly when the mechanism should be invoked remains open; it's clear that it's a good idea for peers and providers, but I'm not sure it's sensible for providers to see the departure of requirers until it actually happens (because providers may have set up creds for the specific requirers, and it'd be unhelpful to cut off their access before they're ready). Thoughts? https://code.launchpad.net/~fwereade/juju-core/prepare-leave-scope/+merge/181065 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : state: RelationUnit.PrepareLeaveScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -66 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/relationunit.go View 1 3 chunks +29 lines, -3 lines 0 comments Download
M state/relationunit_test.go View 1 1 chunk +79 lines, -0 lines 0 comments Download
M state/watcher.go View 1 7 chunks +141 lines, -63 lines 0 comments Download

Messages

Total messages: 4
fwereade
Please take a look.
10 years, 7 months ago (2013-08-20 15:03:25 UTC) #1
wallyworld
The code looks sane. I must confess I don't fully grok the higher level use ...
10 years, 7 months ago (2013-08-30 00:58:49 UTC) #2
fwereade
Please take a look.
9 years, 10 months ago (2014-05-19 14:19:48 UTC) #3
gz
9 years, 10 months ago (2014-05-19 16:29:44 UTC) #4
LGTM. Doc changes needed anywhere?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b