Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 12837046: es53 css sanitizer barfs on <global-name> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by felix8a
Modified:
12 years, 6 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

<style>p { animation-name: foo; }</style> throws a SomethingWidgy error in es53. That's very unfriendly, because the guest-code developer ends up getting a "Server Error" message with no diagnostic details, and it's not at all obvious what to do next to fix it. Since css rules are loaded dynamically at run-time, we can't really know at compile-time what all the rule atoms are, so encountering an unrecognized atom doesn't really merit a SomethingWidgy error. Instead, this CL just fails the match, which makes CSS validator emit a warning about a bad value, drop the value, and proceed. And the guest-code developer can find the warning easily.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/com/google/caja/plugin/CssValidator.java View 1 chunk +6 lines, -2 lines 1 comment Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 1 chunk +12 lines, -0 lines 1 comment Download

Messages

Total messages: 3
felix8a
12 years, 7 months ago (2013-08-14 22:50:18 UTC) #1
MikeSamuel
lgtm https://codereview.appspot.com/12837046/diff/1/src/com/google/caja/plugin/CssValidator.java File src/com/google/caja/plugin/CssValidator.java (right): https://codereview.appspot.com/12837046/diff/1/src/com/google/caja/plugin/CssValidator.java#newcode1347 src/com/google/caja/plugin/CssValidator.java:1347: // Unrecognized atom: fail the match. I guess ...
12 years, 7 months ago (2013-08-15 00:11:46 UTC) #2
felix8a
12 years, 6 months ago (2013-08-19 22:30:21 UTC) #3
@r5564
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b