Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 128350043: [dev.power64] code review 128350043: cmd/9g: fix final fragment in clearfat

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rsc
Modified:
11 years ago
Reviewers:
minux
CC:
minux, gobot, golang-codereviews
Visibility:
Public.

Description

cmd/9g: fix final fragment in clearfat Was re-clearing the beginning of the block instead of end. There may still be a bug in that clearfat assumes unaligned writes are okay. I don't know whether they are.

Patch Set 1 #

Patch Set 2 : diff -r 541b884670bf867a67a99b58fe34dbbe169881a3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 541b884670bf867a67a99b58fe34dbbe169881a3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/cmd/9g/ggen.c View 1 3 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
11 years, 4 months ago (2014-08-15 21:20:26 UTC) #1
minux
Thanks Russ. FTR, This fixes the little-endian image/jpeg and image test failures. I will double ...
11 years, 4 months ago (2014-08-15 23:02:37 UTC) #2
rsc
it might be that we always 8-align things 8 bytes or larger on the stack.
11 years, 4 months ago (2014-08-15 23:03:01 UTC) #3
minux
On 2014/08/15 23:03:01, rsc wrote: > it might be that we always 8-align things 8 ...
11 years, 4 months ago (2014-08-19 02:29:22 UTC) #4
minux
This CL contains two independent bug fixes. Please update the description. cmd/9g: fix setting saved ...
11 years, 4 months ago (2014-08-19 02:36:45 UTC) #5
minux
LGTM after updating the description.
11 years, 4 months ago (2014-08-19 04:42:37 UTC) #6
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
11 years ago (2014-12-19 04:55:48 UTC) #7
gobot
11 years ago (2014-12-19 04:56:53 UTC) #8
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
http://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/NNNNNNN is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b