Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 12834046: a.href now returns a virtualized URL and fragment for the current page. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kpreid_google
Modified:
12 years, 6 months ago
Reviewers:
felix8a, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* jQuery UI tabs expects that <a href="#foo">.href === window.location + '#foo', so implement that. * Fix toString overrides in Domado not working in ES5/3 mode with the + operator. Fixes <http://code.google.com/p/google-caja/issues/detail?id=1835>. @r5570

Patch Set 1 #

Total comments: 2

Patch Set 2 : a.href now returns a virtualized URL and fragment for the current page. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -15 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 6 chunks +52 lines, -5 lines 0 comments Download
M tests/com/google/caja/plugin/test-domado-dom-guest.html View 1 1 chunk +9 lines, -7 lines 0 comments Download
M tests/com/google/caja/plugin/test-domado-global-location.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/third-party-tests.json View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
kpreid_google
12 years, 6 months ago (2013-08-16 23:42:31 UTC) #1
felix8a
https://codereview.appspot.com/12834046/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12834046/diff/1/src/com/google/caja/plugin/domado.js#newcode2217 src/com/google/caja/plugin/domado.js:2217: if (fragless === (document.baseURI || document.location.href)) { what if ...
12 years, 6 months ago (2013-08-21 20:16:49 UTC) #2
ihab.awad
lgtm
12 years, 6 months ago (2013-08-21 21:09:37 UTC) #3
kpreid_google
* jQuery UI tabs expects that <a href="#foo">.href === window.location + '#foo', so implement that. ...
12 years, 6 months ago (2013-08-21 21:20:17 UTC) #4
kpreid_google
https://codereview.appspot.com/12834046/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12834046/diff/1/src/com/google/caja/plugin/domado.js#newcode2217 src/com/google/caja/plugin/domado.js:2217: if (fragless === (document.baseURI || document.location.href)) { On 2013/08/21 ...
12 years, 6 months ago (2013-08-21 21:20:41 UTC) #5
ihab.awad
12 years, 6 months ago (2013-08-21 21:26:35 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b