Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 12815049: Split scanner into two files, algorithm and configuration. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kpreid2
Modified:
12 years, 6 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

test-scan-core.js contains the graph walking algorithm and is almost independent of Caja. test-scan-guest.js contains all the data used to scan the Caja environment. There is one significant change beyond the split itself: the sort ordering for property names is now a parameter to Scanner (and so can live in test-scan-guest.js). @r5576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2305 lines) Patch
M build.xml View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/com/google/caja/plugin/test-scan-core.js View 7 chunks +30 lines, -1424 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.html View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 8 chunks +16 lines, -881 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 6 months ago (2013-08-22 23:29:00 UTC) #1
felix8a
12 years, 6 months ago (2013-08-22 23:44:20 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b