Issue 12814044: Add check for non-static nested class

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12814044: Add check for non-static nested class

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by alexloh

Modified:
11 years, 1 month ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Add check for non-static nested class

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+384 lines, -56 lines)			Patch
M	core/src/main/java/com/google/errorprone/ErrorProneScanner.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	core/src/main/java/com/google/errorprone/bugpatterns/NonStaticInnerClass.java	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A +	core/src/main/java/com/google/errorprone/matchers/ClassModifier.java	View	1 chunk	+9 lines, -6 lines	0 comments	Download
A	core/src/main/java/com/google/errorprone/matchers/HasIdentifier.java	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	core/src/main/java/com/google/errorprone/matchers/Matchers.java	View	4 chunks	+9 lines, -1 line	0 comments	Download
A +	core/src/test/java/com/google/errorprone/bugpatterns/NonStaticInnerClassTest.java	View	1 chunk	+13 lines, -24 lines	0 comments	Download
A	core/src/test/resources/com/google/errorprone/bugpatterns/NonStaticInnerClassNegativeCases.java	View	1 chunk	+87 lines, -0 lines	0 comments	Download
A +	core/src/test/resources/com/google/errorprone/bugpatterns/NonStaticInnerClassPositiveCase1.java	View	1 chunk	+8 lines, -5 lines	0 comments	Download
A	core/src/test/resources/com/google/errorprone/bugpatterns/NonStaticInnerClassPositiveCase1$Inner1.class	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	core/src/test/resources/com/google/errorprone/bugpatterns/NonStaticInnerClassPositiveCase2.java	View	1 chunk	+12 lines, -10 lines	0 comments	Download
A +	core/src/test/resources/com/google/errorprone/bugpatterns/NonStaticInnerClassPositiveCase3.java	View	1 chunk	+9 lines, -10 lines	0 comments	Download