Issue 12797049: Clean up some minor TODOs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12797049: Clean up some minor TODOs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by kpreid2

Modified:
12 years, 6 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* Remove obsolete workaround from test-domado-global testOnloadProp. * Enable disabled tests of assignment to predefined global variables in test-basic-functions. * Remove obsolete code for old-style virtualized attributes from bridal.cloneNode. * Expand comment on document.write's return value. @r5567

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -41 lines)			Patch
M	src/com/google/caja/plugin/bridal.js	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-basic-functions-guest.html	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-domado-global.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages