Issue 127880043: Move MemoryAccessorTester to unittest_util.h/cc for reuse.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 127880043: Move MemoryAccessorTester to unittest_util.h/cc for reuse. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by Siggi

Modified:
9 years, 8 months ago

Reviewers:
Sébastien Marchand

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Move MemoryAccessorTester to unittest_util.h/cc for reuse. R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2250

Patch Set 2 : Address Sebastien's comments. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+347 lines, -338 lines)			Patch
M	syzygy/agent/asan/asan_rtl_unittest.cc	View		2 chunks	+3 lines, -338 lines	0 comments	Download
M	syzygy/agent/asan/unittest_util.h	View	1	2 chunks	+77 lines, -0 lines	0 comments	Download
M	syzygy/agent/asan/unittest_util.cc	View		2 chunks	+267 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Siggi

PTAL - moving the test class to test utils header/source for reuse.

9 years, 8 months ago (2014-08-11 11:03:26 UTC) #1

Sébastien Marchand

lgtm with one comment and one question. https://codereview.appspot.com/127880043/diff/1/syzygy/agent/asan/unittest_util.h File syzygy/agent/asan/unittest_util.h (right): https://codereview.appspot.com/127880043/diff/1/syzygy/agent/asan/unittest_util.h#newcode460 syzygy/agent/asan/unittest_util.h:460: class MemoryAccessorTester ...

9 years, 8 months ago (2014-08-11 12:55:10 UTC) #2

Siggi

Thanks, committing. https://codereview.appspot.com/127880043/diff/1/syzygy/agent/asan/unittest_util.h File syzygy/agent/asan/unittest_util.h (right): https://codereview.appspot.com/127880043/diff/1/syzygy/agent/asan/unittest_util.h#newcode460 syzygy/agent/asan/unittest_util.h:460: class MemoryAccessorTester { On 2014/08/11 12:55:10, Sébastien ...

9 years, 8 months ago (2014-08-11 13:42:42 UTC) #3

Siggi

9 years, 8 months ago (2014-08-11 13:43:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 2250 (presubmit successful).

Expand All Messages | Collapse All Messages