Issue 12782045: state: RelationUnit.InScope() returns an error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12782045: state: RelationUnit.InScope() returns an error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
mp+181077, fwereade

Visibility:
Public.

Description

state: RelationUnit.InScope() returns an error As suggested by fwereade, RelationUnit.InScope()'s implementation has changed to return an error, if it occurs, rather than ignoring it. Changed tests in both state and apiserver/uniter to reflect that change. https://code.launchpad.net/~dimitern/juju-core/111-relationunit-inscope-error-return/+merge/181077 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -92 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	10 chunks	+16 lines, -10 lines	0 comments	Download
M	state/relationunit.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	state/relationunit_test.go	View	25 chunks	+84 lines, -78 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages