apiserver/uniter: (Watch)ConfigSettings in Uniter

apiserver/uniter: (Watch)ConfigSettings in Uniter

This is the last batch of server-side Uniter API
calls working on units:
* WatchConfigSettings
* ConfigSettings

Next, the service-related calls will be added.

https://code.launchpad.net/~dimitern/juju-core/098-apiserver-uniter-unit-ops6/+merge/179748

(do not edit description out of merge proposal)

[dimitern, 2013-08-12 16:42:58]

Please take a look.

[rog, 2013-08-12 16:52:51]

LGTM with a couple of thoughts below.

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:53: Settings Settings
Why not use the charm.Settings type here?

https://codereview.appspot.com/12776043/diff/1/state/apiserver/uniter/uniter_...
File state/apiserver/uniter/uniter_test.go (right):

https://codereview.appspot.com/12776043/diff/1/state/apiserver/uniter/uniter_...
state/apiserver/uniter/uniter_test.go:202: func (s *uniterSuite)
assertNotifyWatcher(c *gc.C, result params.NotifyWatchResults, err error) {
assertOneNotifyWatcherRegistered ?

[gz, 2013-08-12 17:08:30]

LGTM.

[dimitern, 2013-08-12 17:11:46]

Please take a look.

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:53: Settings Settings
On 2013/08/12 16:52:51, rog wrote:
> Why not use the charm.Settings type here?

I didn't want to import stuff in here as much as possible.

https://codereview.appspot.com/12776043/diff/1/state/apiserver/uniter/uniter_...
File state/apiserver/uniter/uniter_test.go (right):

https://codereview.appspot.com/12776043/diff/1/state/apiserver/uniter/uniter_...
state/apiserver/uniter/uniter_test.go:202: func (s *uniterSuite)
assertNotifyWatcher(c *gc.C, result params.NotifyWatchResults, err error) {
On 2013/08/12 16:52:51, rog wrote:
> assertOneNotifyWatcherRegistered ?

Done.

[rog, 2013-08-12 17:53:57]

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12776043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:53: Settings Settings
On 2013/08/12 17:11:46, dimitern wrote:
> On 2013/08/12 16:52:51, rog wrote:
> > Why not use the charm.Settings type here?
> 
> I didn't want to import stuff in here as much as possible.

We already import the charm package from api/params.
I don't see any particular reason not to use it here.