Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 12775044: Add early support for using a complete document as vdoc container. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kpreid2
Modified:
12 years, 6 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This support is documented as experimental, as we do not have complete tests for functionality in the document case. Furthermore, we do not yet use an un-virtualized <html> and <body>, which prevents some of the desirable consequences of using a document. * Modified caja.js to permit documents. * Modified HtmlEmitter to permit documents and implement emitStatic without requiring the node to have an .innerHTML. * Documented functionality in cajajs.xml. * If in a document, emitCss puts stylesheets inside the guest tree, lacking anywhere else to put them. Note that in ES5 mode emitCss is being eliminated. * Add event dispatch hooks to feral documents. (The above last two changes I believe to eliminate the reasons why caja.js previously had a restriction that the <div> container must be in the same document as caja.js was loaded in.) @r5579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -24 lines) Patch
M doc/cajajs/cajajs.xml View 1 chunk +9 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/caja.js View 1 chunk +12 lines, -5 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 chunk +18 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/html-emitter.js View 4 chunks +23 lines, -4 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 2 chunks +5 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/test-cajajs-invocation.js View 4 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 3
kpreid2
12 years, 6 months ago (2013-08-21 17:31:41 UTC) #1
kpreid2
ping
12 years, 6 months ago (2013-08-26 18:33:40 UTC) #2
ihab.awad
12 years, 6 months ago (2013-08-26 20:26:52 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b