Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 12767049: Fixed issue 1842: Safari 5 es5/3 using platform accessors in array-likes badly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by MarkM
Modified:
12 years, 6 months ago
Reviewers:
felix8a, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

On es5/3 on Safari 5, array-likes were implemented with platform getters, but these properties were to be overridden with platform assignment, which doesn't work for inherited accessor properties with no setters. This adds a platform setter to such properties, allowing override by platform assignment.

Patch Set 1 #

Patch Set 2 : Fixed issue 1842: Safari 5 es5/3 using platform accessors in array-likes badly #

Patch Set 3 : Fixed issue 1842: Safari 5 es5/3 using platform accessors in array-likes badly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M src/com/google/caja/es53.js View 1 2 4 chunks +62 lines, -3 lines 0 comments Download

Messages

Total messages: 5
MarkM
12 years, 6 months ago (2013-08-17 20:33:36 UTC) #1
MarkM
On es5/3 on Safari 5, array-likes were implemented with platform getters, but these properties were ...
12 years, 6 months ago (2013-08-17 20:35:58 UTC) #2
ihab.awad
lgtm++
12 years, 6 months ago (2013-08-18 00:05:30 UTC) #3
MarkM
On es5/3 on Safari 5, array-likes were implemented with platform getters, but these properties were ...
12 years, 6 months ago (2013-08-18 01:23:46 UTC) #4
MarkM
12 years, 6 months ago (2013-08-18 01:27:56 UTC) #5
On 2013/08/18 00:05:30, ihab.awad wrote:
> lgtm++

(Ihab also let me know by chat that the comment was unclear.)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b