Issue 12761044: support vendor prefixes in css functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12761044: support vendor prefixes in css functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by felix8a

Modified:
12 years, 6 months ago

Reviewers:
MikeSamuel, kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

linear-gradient() works but -webkit-linear-gradient() gets dropped. this CL fixes that for the client-side css sanitizer. fixing it in the server-side css sanitizer is a little harder (because the leading '-' is parsed as a separate token), so I've just marked a TODO and I'm deferring that for now.

Patch Set 1 #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
M	src/com/google/caja/plugin/sanitizecss.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/CssRewriterTest.java	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	tests/com/google/caja/plugin/sanitizecss_test.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

LGTM https://codereview.appspot.com/12761044/diff/1/tests/com/google/caja/plugin/CssRewriterTest.java File tests/com/google/caja/plugin/CssRewriterTest.java (right): https://codereview.appspot.com/12761044/diff/1/tests/com/google/caja/plugin/CssRewriterTest.java#newcode201 tests/com/google/caja/plugin/CssRewriterTest.java:201: /* Maybe use if (false) instead of comments ...

12 years, 6 months ago (2013-08-21 04:03:30 UTC) #2

@r5568

Expand All Messages | Collapse All Messages