Issue 12741048: provider/ec2: Record ips in Addresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12741048: provider/ec2: Record ips in Addresses

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by gz

Modified:
10 years, 8 months ago

Reviewers:
mp+181097, jameinel

Visibility:
Public.

Description

provider/ec2: Record ips in Addresses Include IPAddress and PublicIPAddress from the EC2 Instance in Addresses output. https://code.launchpad.net/~gz/juju-core/ec2_addresses_extra/+merge/181097 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/ec2/ec2.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	provider/ec2/local_test.go	View	2 chunks	+25 lines, -11 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jameinel

10 years, 8 months ago (2013-08-21 09:52:15 UTC) #2

It seems a bit odd to provide the DNSName and the IP address that is associated
with it.

The actual code + test is LGTM, but I'd like to understand why we need to add
this when we have the DNS name already.

Expand All Messages | Collapse All Messages