Issue 127220043: Automatically build mapreduce diectory when trying to serve locally

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 127220043: Automatically build mapreduce diectory when trying to serve locally (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by jrobbins (chromium)

Modified:
11 years ago

Reviewers:
jrobbins (corp), pgervais

CC:
codereview-list_googlegroups.com

Visibility:
Public.

More Reviews

Description

There has been a repeated question from developers who try to make small contributions to Rietveld: what's wrong when I try to run it? it says mapreduce not found. This change adds a simple Makefile dependency to build the mapreduce directory if it does not already exist.

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pgervais

On 2014/08/12 23:40:24, pgervais wrote: > On 2014/08/12 23:32:23, jrobbins (corp) wrote: > > PTAL. ...

11 years ago (2014-08-12 23:40:46 UTC) #3

jrobbins (corp)

11 years ago (2014-08-12 23:54:31 UTC) #4

On 2014/08/12 23:40:46, pgervais wrote:
> On 2014/08/12 23:40:24, pgervais wrote:
> > On 2014/08/12 23:32:23, jrobbins (corp) wrote:
> > > PTAL.
> > 
> > lgtm ++
> 
> But fix commit message (AutomatiCally)

Fixed.

Committed as
https://code.google.com/p/rietveld/source/detail?r=d3c79e3f6653a51ae9b2bbdfc1...

Expand All Messages | Collapse All Messages