Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 1272042: Update Caja to r4057 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by johnfargo
Modified:
15 years, 10 months ago
Reviewers:
Paul Lindner, shindig.remailer, Jasvir
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This patch updates use of Caja to rev 4057. It updates the calling API as well as its resource-fetching mechanism to use an injected RequestPipeline. Using CajaHtmlParser as GadgetHtmlParser, due to its use/support of namespaces, is required for caja to work as of this CL. Instances using NekoSimplifiedHtmlParser will *not* work when cajoling content! This CL does not switch Shindig's default HTML parser to CajaHtmlParser just yet - a move which is the intended "real" solution - due to a few small lingering issues with namespaced attributes that are being fixed by Caja-team shortly. An enterprising instantiation wishing to support cajoling could implement a GadgetHtmlParser wrapper to both Neko and Caja, delegating to the latter only when the gadget is to be cajoled.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -202 lines) Patch
java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java View 1 chunk +1 line, -1 line 1 comment Download
java/gadgets/pom.xml View 1 chunk +4 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java View 3 chunks +11 lines, -3 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java View 1 chunk +14 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java View 1 chunk +39 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 3 chunks +93 lines, -96 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/RpcServlet.java View 1 chunk +0 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaSocialMarkupHtmlParserTest.java View 1 chunk +19 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/old/CajaCssSanitizerTest.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriterTest.java View 7 chunks +13 lines, -44 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriterTest.java View 8 chunks +20 lines, -47 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/old/SanitizingRequestRewriterTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriterTestBase.java View 3 chunks +17 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/old/BaseRewriterTestCase.java View 4 chunks +17 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriterTest.java View 1 chunk +1 line, -0 lines 0 comments Download
pom.xml View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5
johnfargo
15 years, 10 months ago (2010-05-24 22:51:28 UTC) #1
Paul Lindner
with the exception with the local pathname it appears fine. Did not test locally though.... ...
15 years, 10 months ago (2010-05-24 23:24:20 UTC) #2
fargo
Whoops -- removed and re-ran, tests passed. On Mon, May 24, 2010 at 4:24 PM, ...
15 years, 10 months ago (2010-05-24 23:25:51 UTC) #3
Jasvir
I've been following this along on a separate thread. Thanks for knocking this out fargo! ...
15 years, 10 months ago (2010-05-24 23:29:45 UTC) #4
fargo
15 years, 10 months ago (2010-05-24 23:43:09 UTC) #5
Submitted, thanks!

On Mon, May 24, 2010 at 4:29 PM, <jasvir@gmail.com> wrote:

> I've been following this along on a separate thread.  Thanks for
> knocking this out fargo!
>
> LGTM
>
>
> http://codereview.appspot.com/1272042/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b