Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(617)

Issue 126930043: Make style and JS changes take effect immediately after deploying a version (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by jrobbins (chromium)
Modified:
11 years, 1 month ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Yesterday I deployed a CSS change and found that it took 1h after deployment for users to see it. Also, the old 1h expiration meant that users were downloading these files again each hour. The new way of serving these files puts the rietveld revision in the URL so that each different deployed app version makes a different request that will not use an old cached file. Since we are no longer relying on expiration, we can let it default to 7 days and reduce the number of times users download it again.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M templates/base.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
jrobbins (corp)
PTAL.
11 years, 1 month ago (2014-08-12 17:27:59 UTC) #1
rmistry
LGTM
11 years, 1 month ago (2014-08-12 17:29:13 UTC) #2
jrobbins (corp)
11 years, 1 month ago (2014-08-12 17:38:30 UTC) #3

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b