Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 12690043: generalize css vendor prefix for es53 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by felix8a
Modified:
12 years, 7 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL deletes the vendor-prefix css properties in the css whitelist. To do that without breaking es53 users, this adds some vendor prefix hxandling to the es53 css sanitizer. This isn't quite feature parity with the es5 css sanitizer, because es53 won't handle @-webkit-keyframes and other such cases, but that isn't a new problem, and es53 is going away.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -177 lines) Patch
M src/com/google/caja/lang/css/css-extensions-defs.json View 24 chunks +11 lines, -136 lines 0 comments Download
M src/com/google/caja/lang/css/css-extensions-whitelist.json View 2 chunks +0 lines, -38 lines 0 comments Download
M src/com/google/caja/parser/css/CssTree.java View 1 chunk +4 lines, -0 lines 1 comment Download
M src/com/google/caja/plugin/CssValidator.java View 3 chunks +33 lines, -3 lines 1 comment Download
M src/com/google/caja/plugin/sanitizecss.js View 1 chunk +1 line, -0 lines 1 comment Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 7 months ago (2013-08-09 00:00:33 UTC) #1
MikeSamuel
On 2013/08/09 00:00:33, felix8a wrote: LGTM
12 years, 7 months ago (2013-08-09 16:25:39 UTC) #2
MikeSamuel
12 years, 7 months ago (2013-08-09 19:54:14 UTC) #3
Sorry, my drafts didn't go out with my LGTM

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/parser/css...
File src/com/google/caja/parser/css/CssTree.java (right):

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/parser/css...
src/com/google/caja/parser/css/CssTree.java:501: }
For debugging?

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/plugin/Css...
File src/com/google/caja/plugin/CssValidator.java (right):

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/plugin/Css...
src/com/google/caja/plugin/CssValidator.java:261: }
This is somewhat duplicative of a similar function in CssPropertyPatterns.

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/plugin/san...
File src/com/google/caja/plugin/sanitizecss.js (right):

https://codereview.appspot.com/12690043/diff/1/src/com/google/caja/plugin/san...
src/com/google/caja/plugin/sanitizecss.js:121: // Note: info is duplicated in
CssValidator.java
thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b