Kill irrelevant comment

Kill irrelevant comment

[Mark S. Miller, 2013-08-08 00:54:26]

Actually, what is our policy for comment-only CLs? To I need approval
before submission?


On Wed, Aug 7, 2013 at 5:46 PM, <erights@gmail.com> wrote:

>
https://codereview.appspot.**com/12638043/<https://codereview.appspot.com/126...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
google-caja-discuss+**unsubscribe@googlegroups.com<google-caja-discuss%2Bunsu...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>



-- 
    Cheers,
    --MarkM

[felix8a, 2013-08-08 00:56:06]

lgtm

[kpreid2, 2013-08-08 01:14:48]

LGTM

Actually, I have a suggestion for a further refinement (feel free to not do this
in this CL): Include a rationale on every canRepair:false. In particular, for
the repairs that were written and then deleted, something like "// dead bug, not
worth keeping repair", maybe even including the rev where the repair existed.

[MarkM, 2013-08-08 02:28:54]

On 2013/08/08 01:14:48, kpreid2 wrote:
> LGTM
> 
> Actually, I have a suggestion for a further refinement (feel free to not do
this
> in this CL): Include a rationale on every canRepair:false. In particular, for
> the repairs that were written and then deleted, something like "// dead bug,
not
> worth keeping repair", maybe even including the rev where the repair existed.

Saw this after I submitted, so not in this CL regardless.

I like the idea but doubt I will find the time for it myself. If someone else
does, I'll happily review.

[kpreid2, 2013-08-08 18:49:10]

On 2013/08/08 02:28:54, MarkM wrote:
> I like the idea but doubt I will find the time for it myself. If someone else
> does, I'll happily review.

Filed <https://code.google.com/p/google-caja/issues/detail?id=1836>.