Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 126240043: Added a new flag to specify the ratio of the memory used by the quarantine of the ZebraBlockHeap in… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by peterssen
Modified:
11 years, 4 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Added a new flag to specify the ratio of the memory used by the quarantine of the ZebraBlockHeap in SyzyASan. BUG= R=chrisha@chromium.org, sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2258

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fixed nits #

Total comments: 1

Patch Set 3 : Using the new quarantine ratio flag in the ZebraBlockHeap #

Total comments: 3

Patch Set 4 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M syzygy/agent/asan/asan_runtime.cc View 1 4 chunks +10 lines, -4 lines 0 comments Download
M syzygy/agent/asan/heaps/zebra_block_heap.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M syzygy/agent/asan/heaps/zebra_block_heap.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M syzygy/common/asan_parameters.h View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M syzygy/common/asan_parameters.cc View 1 2 3 5 chunks +16 lines, -2 lines 0 comments Download
M syzygy/common/asan_parameters_unittest.cc View 1 2 3 4 chunks +7 lines, -1 line 0 comments Download
M syzygy/instrument/transforms/asan_transform.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9
peterssen
PTAL. Same CL, different flag.
11 years, 4 months ago (2014-08-14 15:44:10 UTC) #1
Sébastien Marchand
A few nits. https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtime.cc File syzygy/agent/asan/asan_runtime.cc (right): https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtime.cc#newcode17 syzygy/agent/asan/asan_runtime.cc:17: #include <algorithm> Why adding these include ...
11 years, 4 months ago (2014-08-14 21:59:44 UTC) #2
peterssen
PTAL. Fixed nits. https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtime.cc File syzygy/agent/asan/asan_runtime.cc (right): https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtime.cc#newcode17 syzygy/agent/asan/asan_runtime.cc:17: #include <algorithm> On 2014/08/14 21:59:44, Sébastien ...
11 years, 4 months ago (2014-08-15 14:45:40 UTC) #3
Sébastien Marchand
One comment. https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parameters.cc File syzygy/common/asan_parameters.cc (right): https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parameters.cc#newcode159 syzygy/common/asan_parameters.cc:159: const float kDefaultZebraBlockHeapQuarantineRatio = 0.25f; You could ...
11 years, 4 months ago (2014-08-15 15:04:21 UTC) #4
peterssen
On 2014/08/15 15:04:21, Sébastien Marchand wrote: > One comment. > > https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parameters.cc > File syzygy/common/asan_parameters.cc ...
11 years, 4 months ago (2014-08-15 15:35:51 UTC) #5
Sébastien Marchand
lgtm with nits. https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parameters.cc File syzygy/common/asan_parameters.cc (right): https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parameters.cc#newcode380 syzygy/common/asan_parameters.cc:380: // Parse the zebra block heap ...
11 years, 4 months ago (2014-08-15 15:57:20 UTC) #6
chrisha
lgtm minus seb's nits
11 years, 4 months ago (2014-08-15 16:05:33 UTC) #7
peterssen
On 2014/08/15 16:05:33, chrisha wrote: > lgtm minus seb's nits Nits fixed, committing
11 years, 4 months ago (2014-08-15 17:15:27 UTC) #8
peterssen
11 years, 4 months ago (2014-08-15 17:36:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as 2258 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b