Added a new flag to specify the ratio of the memory used by the quarantine of the ZebraBlockHeap in…

Added a new flag to specify the ratio of the memory used by the quarantine of the ZebraBlockHeap in SyzyASan.

BUG=
R=chrisha@chromium.org, sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2258

[peterssen, 2014-08-14 15:44:10]

PTAL. Same CL, different flag.

[Sébastien Marchand, 2014-08-14 21:59:44]

A few nits.

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
File syzygy/agent/asan/asan_runtime.cc (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:17: #include <algorithm>
Why adding these include ? Did you get a warning ?

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:546: // the BlockHeapManager when it's
defined.
indent + 4.

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:548: // zebra_block_heap_quarantine_ratio to
the BlockHeapManager when it's
Ditto.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters.cc
File syzygy/common/asan_parameters.cc (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.cc:185: "zebra_block_heap_quarantine_ratio";
indent + 2.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.cc:380: kParamZebraBlockHeapQuarantineRatio,
indent + 4.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters.h
File syzygy/common/asan_parameters.h (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:114: // ZebraBlockHeap: The  of the
ZebraBlockHeap.
The ?

[peterssen, 2014-08-15 14:45:40]

PTAL. Fixed nits.

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
File syzygy/agent/asan/asan_runtime.cc (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:17: #include <algorithm>
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> Why adding these include ? Did you get a warning ?

Yes, I got a wrong warning.
the warning was caused by a function called transform, the checker mistakenly
assumed it was std::transform and complained.

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:546: // the BlockHeapManager when it's
defined.
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> indent + 4.

Done.

https://codereview.appspot.com/126240043/diff/1/syzygy/agent/asan/asan_runtim...
syzygy/agent/asan/asan_runtime.cc:548: // zebra_block_heap_quarantine_ratio to
the BlockHeapManager when it's
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> Ditto.

Done.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters.cc
File syzygy/common/asan_parameters.cc (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.cc:185: "zebra_block_heap_quarantine_ratio";
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> indent + 2.

Done.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.cc:380: kParamZebraBlockHeapQuarantineRatio,
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> indent + 4.

Done.

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters.h
File syzygy/common/asan_parameters.h (right):

https://codereview.appspot.com/126240043/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:114: // ZebraBlockHeap: The  of the
ZebraBlockHeap.
On 2014/08/14 21:59:44, Sébastien Marchand wrote:
> The ?

Done.

[Sébastien Marchand, 2014-08-15 15:04:21]

One comment.

https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parame...
File syzygy/common/asan_parameters.cc (right):

https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parame...
syzygy/common/asan_parameters.cc:159: const float
kDefaultZebraBlockHeapQuarantineRatio = 0.25f;
You could remove the ZebraBlockHeap::kDefaultQuarantineRatio variable and use
this one to initialize ZebraBlockHeap::quarantine_ratio_ in the ZebraHeap
constructor.

[peterssen, 2014-08-15 15:35:51]

On 2014/08/15 15:04:21, Sébastien Marchand wrote:
> One comment.
> 
>
https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parame...
> File syzygy/common/asan_parameters.cc (right):
> 
>
https://codereview.appspot.com/126240043/diff/20001/syzygy/common/asan_parame...
> syzygy/common/asan_parameters.cc:159: const float
> kDefaultZebraBlockHeapQuarantineRatio = 0.25f;
> You could remove the ZebraBlockHeap::kDefaultQuarantineRatio variable and use
> this one to initialize ZebraBlockHeap::quarantine_ratio_ in the ZebraHeap
> constructor.

Done.

[Sébastien Marchand, 2014-08-15 15:57:20]

lgtm with nits.

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
File syzygy/common/asan_parameters.cc (right):

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
syzygy/common/asan_parameters.cc:380: // Parse the zebra block heap quarantine
ratio  flag.
There's an extra space between ration and flags.

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
File syzygy/common/asan_parameters.h (right):

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
syzygy/common/asan_parameters.h:220: // String names of ZebraHeapZize
parameters.
s/ZebraHeapZize/ZebraBlockHeap/

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
File syzygy/common/asan_parameters_unittest.cc (right):

https://codereview.appspot.com/126240043/diff/40001/syzygy/common/asan_parame...
syzygy/common/asan_parameters_unittest.cc:217:
EXPECT_EQ(kDefaultZebraBlockHeapSize, iparams.zebra_block_heap_size);
EXPECT_EQ(kDefaultZebraBlockHeapQuarantineRatio,
iparams.zebra_block_heap_quarantine_ratio);

[chrisha, 2014-08-15 16:05:33]

lgtm minus seb's nits

[peterssen, 2014-08-15 17:15:27]

On 2014/08/15 16:05:33, chrisha wrote:
> lgtm minus seb's nits

Nits fixed, committing

[peterssen, 2014-08-15 17:36:19]

Committed patchset #4 manually as 2258 (presubmit successful).