Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 126080: Bug 1136: async load module clobbers module handler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by MikeSamuel
Modified:
16 years, 6 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In cajita-module, xhrAsyncLoad creates a stub module handler which is missing a lot of methods. Specifically, it is missing handleUncaughtException which means that if a module throws an exception, then onload handlers will never fire. Submitted @3776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M src/com/google/caja/cajita-module.js View 12 chunks +51 lines, -47 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 6 months ago (2009-10-03 02:44:14 UTC) #1
ihab.awad
16 years, 6 months ago (2009-10-03 03:10:53 UTC) #2
LGTM

Thanks for all the diverse and sundry cleanups.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b