Issue 126074: Simplify the JS lexer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 126074: Simplify the JS lexer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by MikeSamuel

Modified:
16 years, 5 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Simplify number parsing in the JS lexer. This eliminates the need for a joining step in JS lexing. It should not change actual behavior. Submitted @3796

Patch Set 1 #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -237 lines)			Patch
D	src/com/google/caja/lexer/InputElementJoiner.java	View	1 chunk	+0 lines, -138 lines	0 comments	Download
M	src/com/google/caja/lexer/InputElementSplitter.java	View	5 chunks	+12 lines, -27 lines	0 comments	Download
M	src/com/google/caja/lexer/JsLexer.java	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/com/google/caja/lexer/NumberRecognizer.java	View	1 chunk	+71 lines, -66 lines	0 comments	Download
M	src/com/google/caja/lexer/PositionInferer.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages