Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1523)

Issue 12583047: Minor refactoring of TSymbolTable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Alok Priyadarshi
Modified:
10 years, 7 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject@master
Visibility:
Public.

Description

Minor refactoring of TSymbolTable. Used pointers for precision-stack entries as well to avoid unnecessarily re-allocating PrecisionStackLevel whenever the vector needs to resize. Added a scoped class to properly restore symbol-table level after each compile. R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=a6829d5

Patch Set 1 #

Patch Set 2 : attempt to resolve allocator issues #

Patch Set 3 : resolved memory issues #

Patch Set 4 : rebase with TOT #

Total comments: 2

Patch Set 5 : rebase with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -51 lines) Patch
M src/compiler/Compiler.cpp View 1 2 3 4 5 chunks +22 lines, -16 lines 0 comments Download
M src/compiler/SymbolTable.h View 1 2 10 chunks +25 lines, -35 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Alok Priyadarshi
10 years, 7 months ago (2013-08-09 18:30:08 UTC) #1
Alok Priyadarshi
Please ignore this patch for now. I am seeing some issues with WebGL conformance tests.
10 years, 7 months ago (2013-08-12 17:37:09 UTC) #2
Alok Priyadarshi
All issues have been resolved. This is ready to review. Thanks.
10 years, 7 months ago (2013-08-14 16:12:55 UTC) #3
kbr1
LGTM https://codereview.appspot.com/12583047/diff/9001/src/compiler/Compiler.cpp File src/compiler/Compiler.cpp (right): https://codereview.appspot.com/12583047/diff/9001/src/compiler/Compiler.cpp#newcode53 src/compiler/Compiler.cpp:53: mTable->pop(); Would it be more appropriate to do ...
10 years, 7 months ago (2013-08-15 01:40:15 UTC) #4
Alok Priyadarshi
https://codereview.appspot.com/12583047/diff/9001/src/compiler/Compiler.cpp File src/compiler/Compiler.cpp (right): https://codereview.appspot.com/12583047/diff/9001/src/compiler/Compiler.cpp#newcode53 src/compiler/Compiler.cpp:53: mTable->pop(); On 2013/08/15 01:40:15, kbr1 wrote: > Would it ...
10 years, 7 months ago (2013-08-15 04:50:05 UTC) #5
Alok Priyadarshi
10 years, 7 months ago (2013-08-15 21:19:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as ra6829d5 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b