Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(229)

Issue 1258043: Decouple OAuthRequestException from OAuthResponseParams (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by chirag
Modified:
15 years, 8 months ago
Reviewers:
Paul Lindner, beaton, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Decouple OAuthRequestException from OAuthResponseParams 1) Add a formatted description string to the OAuthError enum. This adds meaningful structure to standard oauth error messages. This also allows the descriptions to be reused. 2) Allow for OAuthRequestException exceptions to be thrown outside OAuthResponseParam. In the future, we could change OAuthError to extend caja's MessageTypeInt. This would allow us to reuse their SimpleMessageQueue to collect the context of different errors, and generate a clean requestTrace.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -199 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/AccessorInfoBuilder.java View 2 chunks +2 lines, -3 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthCallbackGenerator.java View 3 chunks +3 lines, -4 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java View 11 chunks +13 lines, -17 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthCallbackGenerator.java View 1 chunk +0 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthError.java View 1 chunk +61 lines, -7 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java View 18 chunks +28 lines, -40 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequestException.java View 1 chunk +131 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java View 7 chunks +36 lines, -78 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/GadgetOAuthCallbackGeneratorTest.java View 3 chunks +2 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/GadgetTokenStoreTest.java View 3 chunks +2 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java View 21 chunks +32 lines, -31 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthResponseParamsTest.java View 5 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 2
chirag
15 years, 10 months ago (2010-05-24 20:05:16 UTC) #1
Paul Lindner
15 years, 10 months ago (2010-05-25 09:30:04 UTC) #2
lgtm --  I do like the error messages inside the enum
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b