Issue 1257041: code review 1257041: syscall: bsd, stub BindToDevice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1257041: code review 1257041: syscall: bsd, stub BindToDevice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by cw

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, adg, golang-dev, r

Visibility:
Public.

Patch Set 2 : code review 1257041: syscall: bsd, implement SockBindToDevice #

Total comments: 1

Patch Set 3 : code review 1257041: syscall: bsd, implement BindToDevice #

Patch Set 4 : code review 1257041: syscall: bsd, implement BindToDevice #

Patch Set 5 : code review 1257041: syscall: bsd, stub BindToDevice #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/pkg/syscall/syscall_bsd.go	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: adg, golang-dev@googlegroups.com, r), I'd like you to review this change.

14 years, 10 months ago (2010-05-18 08:24:16 UTC) #1

rsc

http://codereview.appspot.com/1257041/diff/2001/3001 File src/pkg/syscall/syscall_bsd.go (right): http://codereview.appspot.com/1257041/diff/2001/3001#newcode369 src/pkg/syscall/syscall_bsd.go:369: // SockBindToDevice binds the socket associated with fd to ...

14 years, 10 months ago (2010-05-19 05:37:37 UTC) #2

Hello rsc (cc: adg, golang-dev@googlegroups.com, r), Please take another look.

14 years, 10 months ago (2010-05-19 07:53:48 UTC) #3

rsc

14 years, 10 months ago (2010-05-20 16:39:47 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=ae7280198aaf ***

syscall: bsd, stub BindToDevice

R=rsc
CC=adg, golang-dev, r
http://codereview.appspot.com/1257041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages